Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regenerator runtime error in bundle #3202

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Fix regenerator runtime error in bundle #3202

merged 2 commits into from
Nov 14, 2019

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Nov 13, 2019

Description

Hotfix for #3155, per discussion there. Just queuing this up so that it's possible to publish quickly if necessary.

Relevant Babel docs

Fixes #3155

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested my code on the live network.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.347% when pulling 2f12c2e on issue/3155-hotfix into 22df832 on 1.x.

@cgewecke cgewecke requested a review from nivida November 13, 2019 23:44
@nivida nivida added 1.x 1.0 related issues Bug Addressing a bug labels Nov 14, 2019
Copy link
Contributor

@nivida nivida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgewecke Thanks for doing this hot-fix. This will definitely fix it until the new improved build pipeline got finished.

@nivida nivida merged commit 0f64355 into 1.x Nov 14, 2019
@nivida nivida deleted the issue/3155-hotfix branch November 14, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3.min.js v1.2.2: Uncaught ReferenceError: regeneratorRuntime is not defined
3 participants