Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace istanbul with nyc #3264

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Replace istanbul with nyc #3264

merged 2 commits into from
Dec 9, 2019

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Dec 9, 2019

Description

Istanbul has been deprecated.

Before we were combining runs by renaming folders and using a special merge tool. nyc's report command does this automatically if the different tests are run with --no-clean.

Also, in removing either istanbul or istanbul-combine, we lost a dependency called regenerator-runtime which the build was relying on see broken browser tests. Have added it as a dev dep.

Resources

nyc docs

Type of change

  • Dependency fix (non-breaking change)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.757% when pulling fba6838 on ci/nyc into 5b8c12e on 1.x.

@cgewecke cgewecke added the Review Needed Maintainer(s) need to review label Dec 9, 2019
@cgewecke cgewecke requested a review from nivida December 9, 2019 06:46
@nivida nivida added 1.x 1.0 related issues CI labels Dec 9, 2019
@nivida
Copy link
Contributor

nivida commented Dec 9, 2019

LGTM! 🎊

@nivida nivida removed the Review Needed Maintainer(s) need to review label Dec 9, 2019
@nivida nivida merged commit b35e418 into 1.x Dec 9, 2019
@nivida nivida deleted the ci/nyc branch December 9, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants