Fix misleading web3-providers tsconfig paths (Issue/3336)

[wirednkod]

Description

Issue: The path defined for example in the tsconfig file of the web3-providers-http package is misleading and should get corrected if possible in a non-breaking manner.

Fixes #3336

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• My changes generate no new warnings.
• I ran npm run dtslint with success and extended the tests and types if necessary.
• I ran npm run test:unit with success.

[coveralls]

Coverage remained the same at 90.254% when pulling ddc21aa on wirednkod:issue/3336 into 8c94ca8 on ethereum:1.x.

[ryanio]

Hey @wirednkod thanks for this PR! It LGTM.

Did you by any chance check if any other packages have misleading paths outside the providers packages?

In a future PR would also love your help adding the missing types to the packages you identified in #3336 (comment) web3-core-requestmanager and web3-core-promievent.

[wirednkod]

@ryanio I did - Issue appeared only in the providers package. I'll open new PR for adding the missing types to the packages you identified in #3336 (comment) web3-core-requestmanager and web3-core-promievent.

[ryanio]

Thanks, that would be awesome!

For this PR do you mind adding a small one line Changelog.md entry?

Thanks again.

[wirednkod]

Done that :)

…

On Sat, Apr 11, 2020 at 10:57 PM Ryan Ghods ***@***.***> wrote: Thanks, that would be awesome! For this PR do you mind adding a small one line Changelog.md entry? Thanks again. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3404 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJIOXJH2S6I3IHCSAIAXJ3RMDDSJANCNFSM4LB54KKA> .

[ryanio]

Thanks!

We are prepping the 1.2.7 rc release now so it looks like this PR may have to wait for 1.2.8, but we will be sure to get it in soon! Thanks again.

[nivida]

@ryanio This would probably break existing DApp's. I would test it with different module imports in TS and with different depending projects.

[GregTheGreek]

I think @nivida may be correct here. Ultimately we did just merge #3652 which will eventually solve this issue.

[github-actions]

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.