Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routine cleanup #3443

Merged
merged 6 commits into from
Mar 31, 2020
Merged

Routine cleanup #3443

merged 6 commits into from
Mar 31, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Mar 31, 2020 •
edited
Loading

Description

This PR:

  1. Removes old docs/_build folder
  2. Removes old bower and meteor artifacts
  3. Moves logo assets to own folder
  4. Moves .github assets to own folder
  5. Improves README
    1. Fixes david-dm.org branch to 1.x
    2. Adds links to web3js stackexchange
    3. Better vars for clarity

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@ryanio ryanio force-pushed the routineCleanup branch 3 times, most recently from b83a65a to 8759b87 Compare March 31, 2020 17:49
@coveralls
Copy link

coveralls commented Mar 31, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 86.048% when pulling 79a4f80 on routineCleanup into f9344d8 on 1.x.

@ryanio ryanio added 1.x 1.0 related issues Review Needed Maintainer(s) need to review labels Mar 31, 2020
@ryanio ryanio force-pushed the routineCleanup branch 2 times, most recently from f5f24a5 to 660b25c Compare March 31, 2020 18:10
@cgewecke cgewecke self-requested a review March 31, 2020 18:26
holgerd77
holgerd77 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at the various changes, all look good to me and safe to do. Feel free to merge.

@ryanio
Copy link
Collaborator Author

ryanio commented Mar 31, 2020

@holgerd77 great, thanks!

@cgewecke I'll wait to let you have a look and feel free to merge if everything looks good :)

cgewecke
cgewecke approved these changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice.

@cgewecke cgewecke merged commit 67ea9d0 into 1.x Mar 31, 2020
@holgerd77 holgerd77 deleted the routineCleanup branch March 31, 2020 21:57
@ryanio ryanio mentioned this pull request Apr 15, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Review Needed Maintainer(s) need to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanio @coveralls @holgerd77 @cgewecke