Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eth.clearSubscriptions size property de-referencing bug #3531

Merged
merged 4 commits into from
May 23, 2020
Merged

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented May 21, 2020

Description

The this property is not bound correctly at the web3.eth scope when calling clearSubscriptions:

https://github.com/ethereum/web3.js/blob/740a98258ead66c16b1ec12f3f888baee64694b6/packages/web3-eth/src/index.js#L268

...results in this referring to web3.eth rather than RequestManager when run here:

https://github.com/ethereum/web3.js/blob/740a98258ead66c16b1ec12f3f888baee64694b6/packages/web3-core-requestmanager/src/index.js#L269-L274

Fixes #3527

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@coveralls
Copy link

coveralls commented May 21, 2020

Coverage Status

Coverage remained the same at 89.622% when pulling 5c60d1f on issue/3257 into 53e4cab on 1.x.

@cgewecke cgewecke marked this pull request as ready for review May 21, 2020 19:08
@cgewecke cgewecke added 1.x 1.0 related issues Bug Addressing a bug Review Needed Maintainer(s) need to review labels May 21, 2020
Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, great. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'size' of undefined
3 participants