-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for testing and CI #3532
Conversation
@@ -29,3 +29,6 @@ Fixes #(issue) | |||
- [ ] I ran `npm run build-all` and tested the resulting files from `dist` folder in a browser. | |||
- [ ] I have updated the `CHANGELOG.md` file in the root folder. | |||
- [ ] I have tested my code on the live network. | |||
- [ ] The browser visual inspection check looks ok: [sudden-playground.surge.sh][1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, but might be a little confusing since other PRs can overwrite it at any time. just thinking out loud, i wonder if we could "append" to the index.html
in surge, that would be cool to have a running log of successful (or not) results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this would be ideal: e.g sudden.playground.surge.sh/<branch>/<commit>
As I read surge issue 119, there's no built-in support for this per se and we'd need to maintain our own store of previously published pages.
We can definitely highlight the potential overwrite more clearly in the published page though, will amend this PR for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really great, wish I had this when I started 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks so great! 🎉
Description
Addresses #3528.
Human-readable-version
Draft...would love feedback about stuff to add or clarify.
(Have organized this as table which might not really be the right format, idk)
Fixes #3528
Type of change
Checklist: