-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump web3-providers-ipc oboe version to 2.1.5 #3661
Conversation
So it does not pack 8 MB of test files in its npm package jimhigson/oboe.js#172
@maaktweluit nice, thanks for this PR! would you mind adding an entry in the CHANGELOG.md? |
@ryanio Anytime! Thanks for the quick reply! Updated changelog.md and checked the box in the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok this looks good! I realized though that we also need to commit the updated package-lock for web3-providers-ipc. @maaktweluit do you mind adding that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please commit package-lock for deps bumps
@ryanio @frankiebee Yes, will add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
So it does not pack 8 MB of test files in its npm package jimhigson/oboe.js#172
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.