Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump web3-providers-ipc oboe version to 2.1.5 #3661

Merged
merged 9 commits into from
Aug 31, 2020

Conversation

maaktweluit
Copy link
Contributor

@maaktweluit maaktweluit commented Jul 28, 2020

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

So it does not pack 8 MB of test files in its npm package jimhigson/oboe.js#172

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

So it does not pack 8 MB of test files in its npm package jimhigson/oboe.js#172
@coveralls
Copy link

coveralls commented Jul 28, 2020

Coverage Status

Coverage remained the same at 84.328% when pulling 5b2b5f4 on maaktweluit:patch-1 into 866cb99 on ethereum:1.x.

@ryanio
Copy link
Collaborator

ryanio commented Jul 28, 2020

@maaktweluit nice, thanks for this PR! would you mind adding an entry in the CHANGELOG.md?

@maaktweluit
Copy link
Contributor Author

@ryanio Anytime! Thanks for the quick reply!

Updated changelog.md and checked the box in the description

GregTheGreek
GregTheGreek previously approved these changes Jul 29, 2020
Copy link
Contributor

@GregTheGreek GregTheGreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanio
Copy link
Collaborator

ryanio commented Aug 10, 2020

Ok this looks good! I realized though that we also need to commit the updated package-lock for web3-providers-ipc. @maaktweluit do you mind adding that?

Copy link
Contributor

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit package-lock for deps bumps

@GregTheGreek GregTheGreek added the 1.x 1.0 related issues label Aug 11, 2020
@maaktweluit
Copy link
Contributor Author

@ryanio @frankiebee Yes, will add the package-lock updates later today when I am finished with my current task :)

Copy link
Contributor

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants