Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gnosis dex ci #3673

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Fix gnosis dex ci #3673

merged 1 commit into from
Aug 4, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Aug 4, 2020

Description

This PR sets the APP_ID env for the gnosis dex ci, as it was failing with:

Error: The appId config, or APP_ID environment variable is required. Read more in https://github.com/gnosis/dex-react/wiki/App-Ids-for-Forks

Type of change

  • ci bug fix

@ryanio ryanio added 1.x 1.0 related issues CI labels Aug 4, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+1.002%) to 85.323% when pulling 6c98a05 on fix-ci-gnosis-dex into 54abc8b on 1.x.

@GregTheGreek
Copy link
Contributor

Does this invalidate the claim of #3665 ?

@ryanio
Copy link
Collaborator Author

ryanio commented Aug 4, 2020

no, I don’t believe they are related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants