Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0.0 #3997

Closed
wants to merge 52 commits into from
Closed

Release 3.0.0 #3997

wants to merge 52 commits into from

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Apr 9, 2021

This release contains two breaking changes:

  • Fields related to gas in transaction and receipt output functions now return number strings instead of numbers
  • web3-bzz and web3-shh packages were removed

Changed

Removed

@spacesailor24
Copy link
Contributor Author

Failing ganache-core test is expected as per #3976

@spacesailor24
Copy link
Contributor Author

e2e_mosaic test is failing with: Error BDLR802: Plugin @nomiclabs/buidler-truffle5 requires web3 version ^1.0.0-beta.36 but got 3.0.0.

Continuing release process anyway, tests were previously passing before version bump

@coveralls
Copy link

coveralls commented Apr 9, 2021

Pull Request Test Coverage Report for Build 1169246767

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 423 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.5%) to 72.717%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 25 79.68%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 85 13.04%
packages/web3-eth-accounts/src/index.js 164 25.31%
Totals Coverage Status
Change from base Build 1169167624: -2.5%
Covered Lines: 3279
Relevant Lines: 4260

💛 - Coveralls

@spacesailor24 spacesailor24 marked this pull request as ready for review April 22, 2021 21:45
@spacesailor24 spacesailor24 changed the title Release/3.0.0-rc.0 Release 3.0.0 Apr 22, 2021
frankiebee
frankiebee previously approved these changes Apr 22, 2021
Copy link
Contributor

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

@spacesailor24 spacesailor24 changed the title Release 3.0.0 Release 3.0.0-rc.1 Apr 23, 2021
@GregTheGreek
Copy link
Contributor

@spacesailor24 did you bump to v3.0.0-rc.1?

@spacesailor24 spacesailor24 force-pushed the release/3.0.0 branch 3 times, most recently from af00909 to 460a534 Compare April 23, 2021 21:26
spacesailor24 and others added 21 commits August 25, 2021 18:08
* npm run build for 1.4.0-rc.0

* v1.4.0-rc.0

* 1.4.0 Geth version downgrade (#4149)

* Update pull Geth docker version from stable to pre-london (1.10.3)

* Update CHANGELOG

* v1.4.0
* removed some of the underscore methods in web3-core-method

* removed underscore from bzz

* adding subscriptions

* fixing up test cases

* changing variable names

* removed underscore from formatters.js

* removed underscore from request manager and abi

* removing underscore in the rest of the web3 packages

* fixing exports

* fixing failing testcases

* removing underscore from tests

* addressing feedback

* removing unwanted code from transaction

* removing underscore from remaining packages

* updating change log

* addressing feedback

* adding strict equality

* efficient short circuiting

* fixing test case
* add nonce to send options.

* add nonce to send options.

* Update CHANGELOG.md

* linting

* updating docs

* update web3-shh.rst : whisper-overview broken link (#4170)

whisper overview has been moved from https://github.com/ethereum/go-ethereum/wiki/Whisper to https://eth.wiki/concepts/whisper/whisper-overview

* [Docs] Fixed a broken link (#4151)

Original link gives out a 404, replaced by the closest thing I could find.

* Possible typo in docs (#4088)

I think the author missed a "this" in the phrase

* Typically you will have only one Web3 connection, use const (#3967)

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>

* Removing deprecation notice for HttpProvider (#4008)

* Removing deprecation notice for HttpProvider

From my view, it is just a provider with less capabilities than websockets, but still widely useful — and widely used as well.

@frozeman @nivida @GregTheGreek any thoughts?

* Update include_package-core.rst

* Update CHANGELOG.md

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>

* [Docs] Updated solidity example to modern syntax (#4147)

* [Docs] Updated solidity example to modern syntax

Replaced the old constructor function syntax with the modern one, added 'emit' to event calls, added pragma, added a valid bytes32 value and updated the JSON ABI.

* [Docs] Fixed a broken link (#1)

Original link gives out a 404, replaced by the proper guide.

Co-authored-by: Juan Alonso <Juan.Alonso@trimble.com>

* Revert "[Docs] Fixed a broken link (#1)"

This reverts commit 0de1272.

Co-authored-by: Juan Alonso <Juan.Alonso@trimble.com>

* added EIP-2718 and EIP-1559 documentation

* fixing typo

* addressing feedback

* changing possible types for maxPriorityFeePerGas

* updating maxFeePerGas type

* update changelog

Co-authored-by: exx8 <exx8eran@gmail.com>
Co-authored-by: starwalker00 <68958932+starwalker00@users.noreply.github.com>
Co-authored-by: mongolsteppe <75075420+mongolsteppe@users.noreply.github.com>
Co-authored-by: João Monteiro <joao.monteiro95@hotmail.com>
Co-authored-by: William Entriken <github.com@phor.net>
Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>
Co-authored-by: Ev <evertonfrag@gmail.com>
Co-authored-by: Juan Alonso <Juan.Alonso@trimble.com>
* WIP

* Add missing fields for test runner

* Correct function arguments for getFeeHistory

* getFeeHistory tests with correct arguments

* Init utils.toNumber function

* Rename toNumber test to hexToNumber

* Add inputFormatters to getFeeHistory

* Rename newestBlock to lastBlock. Update types for blockCount and lastBlock

* Add additional tests with different input types

* Add missing function export

* eth-feehistory docs (#4190)

* updating docs

* updating example

* updating types and adding example of list

* Update docs/web3-eth.rst

* Update docs/web3-eth.rst

* Update docs/web3-eth.rst

Co-authored-by: alex <luu.alex@outlook.com>
Co-authored-by: Wyatt Barnes <wyatt@writerof.software>

Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: alex <luu.alex@outlook.com>
Test don't run when only changes to `CHANGELOG.md` have been made
@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Oct 26, 2021
@v0n0
Copy link

v0n0 commented Nov 6, 2021

Is this going to be released? web3-bzz depends on an unmaintained lib (swarm-js), which depends on an old version of another library (ws) that has a security issue. web3-bzz@1.6.0 > swarm-js@0.1.40 > eth-lib@0.1.29 > ws@3.3.3. CVE-2021-32640

@github-actions github-actions bot removed the Stale Has not received enough activity label Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Jan 7, 2022
@v0n0
Copy link

v0n0 commented Jan 7, 2022

ping - any contributors?

@github-actions github-actions bot removed the Stale Has not received enough activity label Jan 8, 2022
@jdevcs jdevcs closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x 3.0 related issues P1 High severity bugs Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants