-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unsubscribe and add a test #4058
Conversation
Pull Request Test Coverage Report for Build 1210555715
💛 - Coveralls |
This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Thank you for opening this PR, apologies it took so long to be looked at Test failure is unrelated to changes, this looks good minus the I believe the test failure is related to #3816, I will be working on updating our tests so this is unblocked Thank you for your patience |
Description
Fix unsubscribe and add a test.
#3992
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.