-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #4210, 4211 - allow non-hex values for eip1559 gas params #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://web3-js-pr-4217.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c42qla9g7hp3ob1apmi0. |
Pull Request Test Coverage Report for Build 1085839186
💛 - Coveralls |
GregTheGreek
changed the title
Closes #4210 - allow non-hex values for eip1559 gas params
Closes #4210, 4211 - allow non-hex values for eip1559 gas params
Jul 31, 2021
spacesailor24
approved these changes
Jul 31, 2021
Merged
This was referenced Nov 24, 2021
This was referenced Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the transaction input formatter to allow the new 1559 gas params to be represented as numbers, bn, string numbers, etc... and then converted to a hex.
Closes #4210 Closes #4211
Note: Still need to add test cases, in transit rn.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.