Accounts Creation - 4.x rewrite #4577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 17, 2021 13:37
luu-alex
commented
Dec 1, 2021
nazarhussain
reviewed
Dec 2, 2021
nazarhussain
suggested changes
Dec 2, 2021
jdevcs
reviewed
Dec 2, 2021
jdevcs
reviewed
Dec 2, 2021
jdevcs
reviewed
Dec 2, 2021
added 2 commits
December 2, 2021 16:11
nazarhussain
approved these changes
Dec 2, 2021
spacesailor24
suggested changes
Dec 3, 2021
jdevcs
approved these changes
Dec 3, 2021
spacesailor24
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #4472
Created Account functions:
Added missing functions from utils:
fixed toChecksum function
Additional details:
Breaking changes, create doesn't take in a parameter anymore, due to the switch in libraries (from eth-lib to ethereum-cryptography for security purposes)
former library we used to generate privateKeys