Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in docs #4616 #4640

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Fix a typo in docs #4616 #4640

merged 3 commits into from
Dec 17, 2021

Conversation

nazarhussain
Copy link
Contributor

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #4616

Type of change

  • Bug fix (non-breaking change which fixes an issue) closes A typo in docs #4616
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Seems a whitespace is needed to render the code part correctly:

CleanShot 2021-12-05 at 18 43 18@2x

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

nazarhussain and others added 2 commits December 17, 2021 15:20
@nazarhussain
Empty commit to trigger CI
2706a9e
@chenxsan @nazarhussain
Fix a typo (#4599)
744e7fd 
* Fix a typo

* update changelog

Co-authored-by: Nazar Hussain <nazarhussain@gmail.com>
@render
Copy link

render bot commented Dec 17, 2021

Your Render PR Server URL is https://web3-js-pr-4640.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6ua7a1g7hp418j23emg.

@nazarhussain nazarhussain self-assigned this Dec 17, 2021
@nazarhussain nazarhussain added the 1.x 1.0 related issues label Dec 17, 2021
jdevcs
jdevcs reviewed Dec 17, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jdevcs jdevcs merged commit 8783f4d into 1.x Dec 17, 2021
@jdevcs jdevcs deleted the nh/4616-docs-typo branch December 17, 2021 18:59
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 1, 2022
Closed
This was referenced Feb 11, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Feb 11, 2022
Open
Open
Open
Open
Open
This was referenced Mar 24, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdevcs jdevcs jdevcs approved these changes

@luu-alex luu-alex luu-alex approved these changes

@spacesailor24 spacesailor24 spacesailor24 approved these changes

Assignees

@nazarhussain nazarhussain

Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A typo in docs
5 participants
@nazarhussain @spacesailor24 @luu-alex @jdevcs @chenxsan