Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web3-eth-contract to use web3-eth methods #4806

Merged
merged 150 commits into from
Mar 4, 2022
Merged

Update web3-eth-contract to use web3-eth methods #4806

merged 150 commits into from
Mar 4, 2022

Conversation

nazarhussain
Copy link
Contributor

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #4685

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@spacesailor24
Add @ethereumjs/tx dependency
3fd0e9e
@spacesailor24
Update Web3BaseProvider to SupportedProviders for Web3Eth constructor
f4f30dd
@spacesailor24
WIP eth-tx
4622b80
@spacesailor24
Add support for undefined values for convertToValidType
8fa2bc5
@spacesailor24
Remove unused Web3BaseProvider
eb2305c
@spacesailor24
WIP eth-tx utils
30b289d
@spacesailor24
Export privateKeyToAddress
ff167ea
@spacesailor24
Add web3-eth-accounts dependency
907c7d0
@spacesailor24
WIP web3-eth-tx util methods
f87ffc6
@spacesailor24
Replace inline errors with error constructors
307201f
@spacesailor24
Change types for transaction r and s properties. Correct hardforks in…
c553765 
… detectTransactionType
@spacesailor24
Init formatTransaction tests and fixture
73c46d6
@spacesailor24
Init detectTransactionType and fixture
dfdf768
@spacesailor24
Add more descriptive error messages
9071db3
@spacesailor24
Logic fixes for validateTransactionForSigning
82d83fd
@spacesailor24
Init validateTransactionForSigning tests and fixtures
953ee21
@spacesailor24
Add esModuleInterop: true to tsconfig
77093a3
@spacesailor24
Small bug fixes and added TODOs
281b6bd
@spacesailor24
Add parent describe to detect_transaction_type test
06f7575
@spacesailor24
Add parent describe to format_transaction test
143922b
@spacesailor24
Add web3-providers-http as dev dependency for tests
fb16061
@spacesailor24
Init populate_transaction tests
dcf9037
@spacesailor24
Move types from eth_tx.ts to types.ts
17e418c
@spacesailor24
Merge branch '4.x' into wyatt/4.x/4652-eth-tx-refactor
b89b7e1
@spacesailor24
Remove TODOs
5c3abbd
@spacesailor24
Merge branch 'wyatt/4.x/4652-eth-tx-refactor' of github.com:ChainSafe…
e6980c3 
…/web3.js into wyatt/4.x/4652-eth-tx-refactor
@spacesailor24
Add missing ,
6311872
@spacesailor24
Remove TODO
11f8097
@spacesailor24
Remove TODO
ef46dbc
@spacesailor24
Fix transaction type import issues
cbe1c20
@nazarhussain nazarhussain self-assigned this Mar 2, 2022
@nazarhussain nazarhussain added the 4.x 4.0 related label Mar 2, 2022
@nazarhussain nazarhussain linked an issue Mar 2, 2022 that may be closed by this pull request
Update web3-eth-contract to use web3-eth methods #4685
Closed
4 tasks
Base automatically changed from wyatt/4.x/4789-transaction-rpc-methods to 4.x March 3, 2022 19:03
@nazarhussain nazarhussain changed the base branch from 4.x to 1.x March 3, 2022 19:21
@nazarhussain nazarhussain changed the base branch from 1.x to 4.x March 3, 2022 19:22
spacesailor24
spacesailor24 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes requested

@nazarhussain nazarhussain merged commit 568b4b2 into 4.x Mar 4, 2022
@nazarhussain nazarhussain deleted the nh/4685-contract-use-eth branch March 4, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacesailor24 spacesailor24 spacesailor24 approved these changes

@luu-alex luu-alex luu-alex approved these changes

@jdevcs jdevcs Awaiting requested review from jdevcs jdevcs is a code owner

Assignees

@nazarhussain nazarhussain

Labels
4.x 4.0 related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update web3-eth-contract to use web3-eth methods
3 participants
@nazarhussain @spacesailor24 @luu-alex