-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: using provided gas options for eip-1559 tx #5012
Update: using provided gas options for eip-1559 tx #5012
Conversation
Pull Request Test Coverage Report for Build 2782780642Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chendatony31 The change looks good. Can you please add at least one test to cover this scenario?
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chendatony31 change log update is also required
8ee9215
to
be8cd46
Compare
Done @jdevcs |
@chendatony31 due to recent merge of another PR there are merge conflicts, could you fix those. |
@jdevcs Any plan to merge this PR? As it has been about 3 months |
Description
We should use provided gas options for eip-1559 tx same as the legacy ones, and avoid useless RPC requests
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.