Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem deleting account when checksummed address is equal to lowercase address #5050

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Problem deleting account when checksummed address is equal to lowercase address #5050

merged 2 commits into from
Jul 5, 2022

Conversation

andreistefanwork
Copy link

@andreistefanwork andreistefanwork commented May 18, 2022 •
edited
Loading

…lowercase are equal #5049

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@andreistefanwork andreistefanwork mentioned this pull request May 18, 2022
Closed
1 task
@nazarhussain nazarhussain changed the title fix remove wallet using an index when an account address and address … Problem deleting account when checksummed address is equal to lowercase address May 18, 2022
@nazarhussain nazarhussain linked an issue May 18, 2022 that may be closed by this pull request
Problem deleting account when checksummed address is equal to lowercase address #5049
Closed
1 task
@nazarhussain
Copy link
Contributor

@andreistefanwork Please add an entry to CHANGELOG.md rest LGTM.

@coveralls
Copy link

coveralls commented May 18, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2346190968

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 72.193%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/web3-eth-accounts/src/index.js 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
packages/web3-eth-accounts/lib/index.js 9 85.43%
Totals Coverage Status
Change from base Build 2337627991: -0.02%
Covered Lines: 3373
Relevant Lines: 4403
💛 - Coveralls

@andreistefanwork
Copy link
Author

@nazarhussain Thanks for checking it out, entry added in CHANGELOG.md

@andreistefanwork
Copy link
Author

but I added it under 1.7.4, and it needs to be in 1.7.5, just like this other PR: #5048

I think I'll wait for a resolution on #5048, and eventually rebase on 1.x after 1.7.5 entry will be part of CHANGELOG.md

@jdevcs jdevcs added 1.x 1.0 related issues Future Release For future release. labels May 18, 2022
@andreistefanwork andreistefanwork force-pushed the bugfix/5049 branch 3 times, most recently from b41ac4d to 772dcd0 Compare June 23, 2022 10:55
@jdevcs jdevcs changed the base branch from 1.x to junaid/acctchecksumdelfix July 5, 2022 10:38
@jdevcs jdevcs merged commit 9df6caa into web3:junaid/acctchecksumdelfix Jul 5, 2022
@jdevcs jdevcs mentioned this pull request Jul 5, 2022
Merged
16 tasks
@jdevcs
Copy link
Contributor

jdevcs commented Jul 5, 2022

Merged via #5202

jdevcs added a commit that referenced this pull request Jul 5, 2022
@jdevcs @andreistefanwork
fix remove wallet using an index when an account address and address …
46b5a5b 
…lowercase are equal #5049 (#5050) (#5202)

Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>

Co-authored-by: Andrei Stefan <andrei.stefan.work@gmail.com>
@andreistefanwork andreistefanwork deleted the bugfix/5049 branch July 5, 2022 14:18
@snyk-bot snyk-bot mentioned this pull request Aug 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietro-lopes pietro-lopes pietro-lopes approved these changes

@jdevcs jdevcs jdevcs approved these changes

@avkos avkos avkos approved these changes

@nazarhussain nazarhussain nazarhussain approved these changes

@luu-alex luu-alex Awaiting requested review from luu-alex

@nikoulai nikoulai Awaiting requested review from nikoulai

@spacesailor24 spacesailor24 Awaiting requested review from spacesailor24

Assignees
No one assigned
Labels
1.x 1.0 related issues Future Release For future release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem deleting account when checksummed address is equal to lowercase address
6 participants
@andreistefanwork @nazarhussain @coveralls @jdevcs @avkos @pietro-lopes