-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: add missing function type "receive" #5165
Fix: add missing function type "receive" #5165
Conversation
This PR adds missing type "receive" example in solidity: ```solidity receive() external payable { // any code } ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itxtoledo Thanks for your contribution. changelog.md update is also required.
Pull Request Test Coverage Report for Build 2867694442Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
* Fix: add missing function type "receive" This PR adds missing type "receive" example in solidity: ```solidity receive() external payable { // any code } ``` * Update Changgelog * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com> Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com> Co-authored-by: Alex <alex.luu@mail.utoronto.ca> Co-authored-by: Alex <luu.alex98@gmail.com> Co-authored-by: Gustavo <gustavo@obex.pw> Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com> Co-authored-by: Alex <alex.luu@mail.utoronto.ca> Co-authored-by: Alex <luu.alex98@gmail.com>
Merged into 1.x via #5165 |
This PR adds missing type "receive"
example in solidity:
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.