-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sha3
and sha3Raw
type definitions to accept Buffer
#5357
Merged
Muhammad-Altabba
merged 5 commits into
1.x
from
feature/5351/update-sha3-type-def-to-accept-buffer
Aug 18, 2022
Merged
Update sha3
and sha3Raw
type definitions to accept Buffer
#5357
Muhammad-Altabba
merged 5 commits into
1.x
from
feature/5351/update-sha3-type-def-to-accept-buffer
Aug 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://web3-js-pr-5357.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbuee6cgqg41claif300. |
Muhammad-Altabba
requested review from
jdevcs,
nikoulai,
avkos,
luu-alex and
spacesailor24
August 17, 2022 13:11
Muhammad-Altabba
force-pushed
the
feature/5351/update-sha3-type-def-to-accept-buffer
branch
from
August 17, 2022 13:15
d161a01
to
d5f4b5d
Compare
luu-alex
approved these changes
Aug 17, 2022
nikoulai
approved these changes
Aug 17, 2022
jdevcs
approved these changes
Aug 18, 2022
This PR should be merged after #5354 |
Pull Request Test Coverage Report for Build 2884449980
💛 - Coveralls |
Muhammad-Altabba
deleted the
feature/5351/update-sha3-type-def-to-accept-buffer
branch
August 18, 2022 18:40
Merged
This was referenced Oct 23, 2022
This was referenced Jan 2, 2023
This was referenced Jan 2, 2023
This was referenced Feb 15, 2023
This was referenced Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #(5351)
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.