-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoding EIP-838 error codes #5434
Conversation
Your Render PR Server URL is https://web3js-docs-pr-5434.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ccgeuusgqg49ca75k98g. |
This pull request introduces 1 alert when merging bfa0831 into 7e236d0 - view on LGTM.com new alerts:
|
…-parameters' into feature/4235/eip-838-error-codes
…/ChainSafe/web3.js into feature/4235/eip-838-error-codes
This pull request introduces 1 alert when merging 262196e into 7e236d0 - view on LGTM.com new alerts:
|
fa08a88
to
d15d63f
Compare
The errors in the Pipeline are not related to this MR and they are addressed here: #5456. |
Description
Implements the logic and a test case for #(4235). However, another MR will be done to add more tests and further improvements.
Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.