Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoding EIP-838 error codes #5434

Merged
merged 18 commits into from
Sep 20, 2022
Merged

Conversation

Muhammad-Altabba
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba commented Sep 13, 2022

Description

Implements the logic and a test case for #(4235). However, another MR will be done to add more tests and further improvements.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@render
Copy link

render bot commented Sep 13, 2022

@Muhammad-Altabba Muhammad-Altabba marked this pull request as draft September 13, 2022 21:01
@Muhammad-Altabba Muhammad-Altabba added the 4.x 4.0 related label Sep 13, 2022
@lgtm-com
Copy link

lgtm-com bot commented Sep 13, 2022

This pull request introduces 1 alert when merging bfa0831 into 7e236d0 - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2022

This pull request introduces 1 alert when merging 262196e into 7e236d0 - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@Muhammad-Altabba Muhammad-Altabba changed the title [Draft] Decoding EIP-838 error codes Decoding EIP-838 error codes Sep 19, 2022
@Muhammad-Altabba
Copy link
Contributor Author

The errors in the Pipeline are not related to this MR and they are addressed here: #5456.

@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review September 19, 2022 09:35
@Muhammad-Altabba Muhammad-Altabba requested review from jdevcs, avkos and luu-alex and removed request for jdevcs September 19, 2022 09:36
@Muhammad-Altabba Muhammad-Altabba merged commit 5d64737 into 4.x Sep 20, 2022
@Muhammad-Altabba Muhammad-Altabba deleted the feature/4235/eip-838-error-codes branch September 20, 2022 11:42
@jdevcs jdevcs mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants