Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BigInt when decoding functions' and events' parameters returned from Smart Contracts calls and events #5435

Conversation

Muhammad-Altabba
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba commented Sep 13, 2022

Description

Fixes #(issue)

I also added innerError as optional property inside Web3Errro.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@Muhammad-Altabba Muhammad-Altabba added the 4.x 4.0 related label Sep 13, 2022
@render
Copy link

render bot commented Sep 13, 2022

@Muhammad-Altabba Muhammad-Altabba changed the title use BigInt when returning the encoded function parameters Use BigInt when returning the encoded function parameters Sep 13, 2022
@Muhammad-Altabba Muhammad-Altabba added the Bug Addressing a bug label Sep 14, 2022
@Muhammad-Altabba Muhammad-Altabba changed the title Use BigInt when returning the encoded function parameters Use BigInt when decoding functions' and events' parameters Sep 16, 2022
@Muhammad-Altabba Muhammad-Altabba changed the title Use BigInt when decoding functions' and events' parameters Use BigInt when decoding functions' and events' parameters returned from Smart Contracts calls and events Sep 16, 2022
@Muhammad-Altabba Muhammad-Altabba merged commit 311d5be into 4.x Sep 16, 2022
@Muhammad-Altabba Muhammad-Altabba deleted the fix/5431/use-BigInt-when-returning-the-encoded-function-parameters branch September 16, 2022 04:58
@jdevcs jdevcs mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants