Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setImmediate Not Defined in Browsers Fix #5450

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Sep 16, 2022

What This PR Does

setImmediate is not supported by most browsers. This popular package was added to web3-eth package to add a polyfill for browsers or use native Node.js implementation when available

Note I attempted to figure out why our sendTransaction, sendSignedTransaction and subscribe test didn't fail when running within the browser when using Cypress, but couldn't figure it out. Instead I manually tested that adding this package fixes the issue with both the minified build and importing via yarn and building with webpack


Added

@spacesailor24 spacesailor24 added the 4.x 4.0 related label Sep 16, 2022
@spacesailor24 spacesailor24 self-assigned this Sep 16, 2022
@spacesailor24 spacesailor24 marked this pull request as ready for review September 16, 2022 02:56
@spacesailor24 spacesailor24 merged commit 53b1b88 into 4.x Sep 16, 2022
@spacesailor24 spacesailor24 deleted the wyatt/4.x/set-immediate-fix branch September 16, 2022 14:33
@jdevcs jdevcs mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants