setImmediate Not Defined in Browsers Fix
#5450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacesailor24
commented
Sep 16, 2022
spacesailor24
requested review from
jdevcs,
nazarhussain,
Muhammad-Altabba,
avkos,
luu-alex and
nikoulai
and removed request for
nazarhussain
spacesailor24
commented
Sep 16, 2022
luu-alex
approved these changes
Sep 16, 2022
jdevcs
approved these changes
Sep 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Does
setImmediate is not supported by most browsers. This popular package was added to
web3-ethpackage to add a polyfill for browsers or use native Node.js implementation when availableNote I attempted to figure out why our
sendTransaction,sendSignedTransactionandsubscribetest didn't fail when running within the browser when using Cypress, but couldn't figure it out. Instead I manually tested that adding this package fixes the issue with both the minified build and importing via yarn and building with webpackAdded
setImmediateNot Defined in Browsers Fix #5450)