Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wallet.encrypt function signature 4.x #5581

Merged
merged 12 commits into from
Nov 9, 2022

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Nov 2, 2022

Description

Fixes #5188

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@avkos avkos added the 4.x 4.0 related label Nov 2, 2022
@luu-alex
Copy link
Contributor

luu-alex commented Nov 3, 2022

Looks good 👍

@render
Copy link

render bot commented Nov 8, 2022

@avkos avkos requested a review from jdevcs November 8, 2022 01:23
CHANGELOG.md Outdated Show resolved Hide resolved
avkos and others added 3 commits November 8, 2022 15:25
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
@avkos avkos requested a review from jdevcs November 8, 2022 15:26
@avkos avkos merged commit b967954 into 4.x Nov 9, 2022
@avkos avkos deleted the ok/5188-Update-Wallet.encrypt-function-signature---4.x branch November 9, 2022 19:07
@spacesailor24 spacesailor24 mentioned this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants