Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-1193 providers #5683

Merged
merged 29 commits into from
Jan 10, 2023
Merged

EIP-1193 providers #5683

merged 29 commits into from
Jan 10, 2023

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Dec 6, 2022 •
edited
Loading

Description

implementation of WS provider
#4656
#5460

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@render
Copy link

render bot commented Dec 6, 2022

Your Render PR Server URL is https://atweb3js-docs-pr-5683.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ce79b06n6mphhrp7ad00.

jdevcs
jdevcs reviewed Dec 6, 2022
View reviewed changes
packages/web3-providers-ws/src/index.ts Show resolved Hide resolved
packages/web3-providers-ws/src/Eip1193Provider.ts Outdated Show resolved Hide resolved
packages/web3-providers-ws/src/Eip1193Provider.ts Outdated Show resolved Hide resolved
packages/web3-providers-ws/src/Eip1193Provider.ts Outdated Show resolved Hide resolved
packages/web3-providers-ws/src/Eip1193Provider.ts Outdated Show resolved Hide resolved
packages/web3-providers-ws/src/Eip1193Provider.ts Outdated Show resolved Hide resolved
@jdevcs
Copy link
Contributor

jdevcs commented Dec 7, 2022

Thanks @avkos good work

@avkos avkos marked this pull request as ready for review December 12, 2022 23:23
jdevcs
jdevcs reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/web3/web3.js/actions/runs/3700485520/jobs/6269015383#step:4:609. should be investigated as discussed.

@avkos
Copy link
Contributor Author

avkos commented Jan 5, 2023

I've created a separate task to investigate the stuck problem #5730

@avkos avkos requested a review from jdevcs January 5, 2023 16:58
@jdevcs
Copy link
Contributor

jdevcs commented Jan 9, 2023

@avkos Please also add changelog in packages and also in root. Thanks

@jdevcs
Copy link
Contributor

jdevcs commented Jan 9, 2023

PR LGTM

@github-actions github-actions bot temporarily deployed to Preview: (ok/4656-IPC-provider-subscription-randomly-not-working) January 10, 2023 15:19 Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cc45ff6
Status: ✅  Deploy successful!
Preview URL: https://7d82ba38.web3-js-docs.pages.dev
Branch Preview URL: https://ok-4656-ipc-provider-subscri.web3-js-docs.pages.dev

View logs

@github-actions github-actions bot temporarily deployed to Preview: (ok/4656-IPC-provider-subscription-randomly-not-working) January 10, 2023 15:53 Inactive
@avkos avkos merged commit 0d9412d into 4.x Jan 10, 2023
@avkos avkos deleted the ok/4656-IPC-provider-subscription-randomly-not-working branch January 10, 2023 17:29
@spacesailor24 spacesailor24 mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdevcs jdevcs jdevcs approved these changes

@nikoulai nikoulai nikoulai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avkos @jdevcs @nikoulai