Fix Webpack Build for web3-validator
#5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacesailor24
requested review from
avkos,
nikoulai,
Muhammad-Altabba,
luu-alex and
jdevcs
|
Your Render PR Server URL is https://atweb3js-docs-pr-5710.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cegi6ao2i3mo1u7gfdcg. |
nikoulai
approved these changes
Jan 3, 2023
jdevcs
approved these changes
Jan 3, 2023
luu-alex
approved these changes
Jan 3, 2023
avkos
approved these changes
Jan 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @jdevcs, the minified filename for
web3-validatorWeb3pack build was changed fromindex.min.js(which interferes withweb3's minified filename) toweb3-validator.min.jsAdditionally, this PR adds
npxto Verdaccio script to make it easier to run scripts locallycloses #5706