Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using latest lighthouse docker image in tests #5741

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jan 10, 2023

Description

#4936

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@jdevcs jdevcs added the 1.x 1.0 related issues label Jan 10, 2023
@jdevcs jdevcs requested a review from a team January 10, 2023 14:20
@jdevcs jdevcs self-assigned this Jan 10, 2023
@coveralls
Copy link

coveralls commented Jan 10, 2023

Pull Request Test Coverage Report for Build 3884212666

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.676%

Totals Coverage Status
Change from base Build 3856126029: 0.0%
Covered Lines: 3432
Relevant Lines: 4446

💛 - Coveralls

@jdevcs jdevcs marked this pull request as ready for review January 10, 2023 14:54
@jdevcs
Copy link
Contributor Author

jdevcs commented Jan 10, 2023

Its required for 1.8.2 RC CL tests.

@jdevcs jdevcs merged commit b995b9e into 1.x Jan 10, 2023
@jdevcs jdevcs deleted the junaid/1xCLTestsfix branch January 10, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants