Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty job to unstuck actions in 1.x #5932

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Add empty job to unstuck actions in 1.x #5932

merged 4 commits into from
Mar 20, 2023

Conversation

nikoulai
Copy link
Contributor

Description

closes #5584

@nikoulai nikoulai added the 1.x 1.0 related issues label Mar 16, 2023
@nikoulai nikoulai self-assigned this Mar 16, 2023
@coveralls
Copy link

coveralls commented Mar 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4445874980

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 273 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.4%) to 74.975%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 2 64.29%
packages/web3-core-helpers/src/formatters.js 9 83.86%
packages/web3-core-helpers/src/errors.js 31 1.47%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 40 40.3%
packages/web3-utils/src/utils.js 46 10.39%
packages/web3-eth-accounts/src/index.js 111 22.94%
Totals Coverage Status
Change from base Build 4345508110: 2.4%
Covered Lines: 3336
Relevant Lines: 4196
💛 - Coveralls

@nikoulai nikoulai changed the title Add empty job Add empty job to unstuck actions in 1.x Mar 16, 2023
avkos
avkos requested changes Mar 16, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@nikoulai nikoulai requested a review from avkos March 17, 2023 09:02
@nikoulai nikoulai merged commit 5508f94 into 1.x Mar 20, 2023
@nikoulai nikoulai deleted the nikos/5584/stuck-actions branch March 20, 2023 15:02
@jdevcs jdevcs mentioned this pull request Mar 20, 2023
Merged
This was referenced Jun 1, 2023
Open
Open
Open
Open
Open
@Manny27nyc Manny27nyc mentioned this pull request Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdevcs jdevcs jdevcs approved these changes

@luu-alex luu-alex luu-alex approved these changes

@avkos avkos avkos approved these changes

@spacesailor24 spacesailor24 Awaiting requested review from spacesailor24

@Muhammad-Altabba Muhammad-Altabba Awaiting requested review from Muhammad-Altabba Muhammad-Altabba is a code owner

Assignees

@nikoulai nikoulai

Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
5 participants
@nikoulai @coveralls @avkos @luu-alex @jdevcs