-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
min build whitelisting #6132
min build whitelisting #6132
Conversation
@@ -21,7 +21,8 @@ | |||
}, | |||
"files": [ | |||
"lib/**/*", | |||
"src/**/*" | |||
"src/**/*", | |||
"dist/**/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a PR in past where lib and dist both directories are created for outputs, dist was not whitelisted, so due to current CDN structure web3.min is not available in last few RCs as its not uploaded to npm due to filtering,
Its fixed here.
tested dist/min..
including via yarn pack
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6132 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 197 197
Lines 7541 7541
Branches 2059 2059
=======================================
Hits 6588 6588
Misses 953 953
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Deploying with Cloudflare Pages
|
Description
#5743
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.