-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors not caught in 4.x #6623
Errors not caught in 4.x #6623
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
Latest commit: |
a368780
|
Status: | ✅ Deploy successful! |
Preview URL: | https://3cf001df.web3-js-docs.pages.dev |
Branch Preview URL: | https://ok-6500-errors-not-caught-in.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6623 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 214 214
Lines 8088 8089 +1
Branches 2163 2163
=======================================
+ Hits 7300 7301 +1
Misses 788 788
Flags with carried forward coverage won't be shown. Click here to find out more.
|
packages/web3-eth-contract/test/integration/contract_erc20.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add changelogs before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @avkos,
Could you please also increase the test coverage?
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6500
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.