Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the deploy function to accept parameters even when no ABI was provided to the Contract #6635

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #6634

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Dec 3, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 590 KB 591 KB 882 bytes 0.15%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 572 KB 573 KB 886 bytes 0.15%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 999 bytes -4 bytes -0.40%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

Copy link

cloudflare-pages bot commented Dec 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6f5188a
Status: ✅  Deploy successful!
Preview URL: https://7776cebf.web3-js-docs.pages.dev
Branch Preview URL: https://6634-fix-if-the-contract-abi.web3-js-docs.pages.dev

View logs

…ypes-of-the-contract-constructor-and-the-methods-does-not-accept-parameters
@Muhammad-Altabba Muhammad-Altabba changed the title [DRAFT] Allow the deploy function to accept parameters even when no ABI was provided to the Contract Allow the deploy function to accept parameters even when no ABI was provided to the Contract Dec 4, 2023
@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review December 4, 2023 14:10
…ct-abi-not-passed-the-types-of-the-contract-constructor-and-the-methods-does-not-accept-parameters
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #6635 (6f5188a) into 4.x (e1080d9) will increase coverage by 0.00%.
The diff coverage is 92.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6635   +/-   ##
=======================================
  Coverage   91.01%   91.02%           
=======================================
  Files         214      214           
  Lines        8121     8141   +20     
  Branches     2174     2181    +7     
=======================================
+ Hits         7391     7410   +19     
- Misses        730      731    +1     
Flag Coverage Δ
UnitTests 91.02% <92.59%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

…ypes-of-the-contract-constructor-and-the-methods-does-not-accept-parameters
…ypes-of-the-contract-constructor-and-the-methods-does-not-accept-parameters
…ypes-of-the-contract-constructor-and-the-methods-does-not-accept-parameters
@Muhammad-Altabba Muhammad-Altabba merged commit fa4c72b into 4.x Dec 15, 2023
61 of 65 checks passed
@Muhammad-Altabba Muhammad-Altabba deleted the 6634-fix-if-the-contract-abi-not-passed-the-types-of-the-contract-constructor-and-the-methods-does-not-accept-parameters branch December 15, 2023 16:22
@luu-alex luu-alex mentioned this pull request Jan 10, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the contract ABI not passed, the deploy method (the smart contract constructor) does not accept parameters
3 participants