-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Unit test coverage for web3-eth above 90% #6663
Increase Unit test coverage for web3-eth above 90% #6663
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged No assets were unchanged |
Deploying with
|
Latest commit: |
97cc1b5
|
Status: | ✅ Deploy successful! |
Preview URL: | https://afa36341.web3-js-docs.pages.dev |
Branch Preview URL: | https://6566-increase-web3-eth-unit.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6663 +/- ##
==========================================
+ Coverage 87.37% 91.46% +4.09%
==========================================
Files 197 214 +17
Lines 7548 8155 +607
Branches 2059 2193 +134
==========================================
+ Hits 6595 7459 +864
+ Misses 953 696 -257
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
undefined, | ||
chainId: common.chainId | ||
? common.chainId() | ||
: BigInt((common as unknown as CommonType).customChain?.chainId) ?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Fixes #6566
Also it fix issues with composing transaction config. However, it seems to need more on this. And a follow up issue was created in this regard: #6666
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.