-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hardhat #6719
Add hardhat #6719
Conversation
Deploying with Cloudflare Pages
|
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6719 +/- ##
==========================================
+ Coverage 87.37% 92.03% +4.65%
==========================================
Files 197 214 +17
Lines 7548 8171 +623
Branches 2059 2200 +141
==========================================
+ Hits 6595 7520 +925
+ Misses 953 651 -302
Flags with carried forward coverage won't be shown. Click here to find out more.
|
packages/web3-eth-contract/test/integration/contract_methods.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Could you please fix the failing tests which are not failing in other PRs?
@Muhammad-Altabba testcases are now passing, ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not part of this PR but also update snapshot of tests so all unit tests should be passing. Thanks @luu-alex
feedback is addressed mentioned by Alex and Muhammad is OOO.
Description
removes ganache test suites and tests hardhat http integration (as discussed from calls).
replaces ganache browser test suites with hardhat test suites.
personal tests are skipped as hardhat and geth do not support personal methods
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.