Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardhat #6719

Merged
merged 48 commits into from
Feb 5, 2024
Merged

Add hardhat #6719

merged 48 commits into from
Feb 5, 2024

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Jan 12, 2024

Description

removes ganache test suites and tests hardhat http integration (as discussed from calls).
replaces ganache browser test suites with hardhat test suites.
personal tests are skipped as hardhat and geth do not support personal methods

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

cloudflare-workers-and-pages bot commented Jan 12, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5dfed6b
Status: ✅  Deploy successful!
Preview URL: https://49810ae8.web3-js-docs.pages.dev
Branch Preview URL: https://add-hardhat.web3-js-docs.pages.dev

View logs

Copy link

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 618 KB 618 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 601 KB 601 KB 0 0.00%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 999 bytes 999 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

Copy link

github-actions bot commented Jan 12, 2024

Benchmark

Benchmark suite Current: 38dabb2 Previous: 6c075db Ratio
processingTx 9609 ops/sec (±3.94%) 9301 ops/sec (±4.81%) 0.97
processingContractDeploy 42435 ops/sec (±6.79%) 39129 ops/sec (±7.62%) 0.92
processingContractMethodSend 19659 ops/sec (±7.37%) 19443 ops/sec (±5.19%) 0.99
processingContractMethodCall 39984 ops/sec (±6.24%) 38971 ops/sec (±6.34%) 0.97
abiEncode 45661 ops/sec (±7.49%) 44252 ops/sec (±6.92%) 0.97
abiDecode 31219 ops/sec (±8.29%) 30419 ops/sec (±8.89%) 0.97
sign 1604 ops/sec (±3.71%) 1656 ops/sec (±4.08%) 1.03
verify 382 ops/sec (±0.43%) 373 ops/sec (±0.78%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Merging #6719 (a235820) into 4.x (4358140) will increase coverage by 4.65%.
Report is 163 commits behind head on 4.x.
The diff coverage is 95.84%.

❗ Current head a235820 differs from pull request most recent head 38dabb2. Consider uploading reports for the commit 38dabb2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6719      +/-   ##
==========================================
+ Coverage   87.37%   92.03%   +4.65%     
==========================================
  Files         197      214      +17     
  Lines        7548     8171     +623     
  Branches     2059     2200     +141     
==========================================
+ Hits         6595     7520     +925     
+ Misses        953      651     -302     
Flag Coverage Δ
UnitTests 92.03% <95.84%> (+4.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Could you please fix the failing tests which are not failing in other PRs?

@luu-alex
Copy link
Contributor Author

@Muhammad-Altabba testcases are now passing, ready for review :)

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not part of this PR but also update snapshot of tests so all unit tests should be passing. Thanks @luu-alex

@luu-alex
Copy link
Contributor Author

@jdevcs muhammad updates it in his PR

@jdevcs jdevcs dismissed Muhammad-Altabba’s stale review February 5, 2024 15:22

feedback is addressed mentioned by Alex and Muhammad is OOO.

@luu-alex luu-alex merged commit e5673ca into 4.x Feb 5, 2024
14 of 17 checks passed
@luu-alex luu-alex deleted the add-hardhat branch February 5, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants