Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed hardhat/web3v4 tutorial #6806

Merged
merged 6 commits into from
Feb 19, 2024
Merged

Completed hardhat/web3v4 tutorial #6806

merged 6 commits into from
Feb 19, 2024

Conversation

bobeu
Copy link
Contributor

@bobeu bobeu commented Feb 10, 2024

Tutorial completed!

@bobeu bobeu mentioned this pull request Feb 10, 2024
Closed
@SantiagoDevRel
Copy link
Member

Great job🎉! LGTM

@bobeu
Copy link
Contributor Author

bobeu commented Feb 11, 2024 •
edited

Great job🎉! LGTM

Thank you @SantiagoDevRel
I saw the changes you made. Awesome! Has the PR merged?

@SantiagoDevRel
Copy link
Member

SantiagoDevRel commented Feb 11, 2024 •
edited

No, It'll be reviewed/approved by the devs and after you get 2 approvals you can squash and merge (it might take a couple of days) @bobeu

jdevcs
jdevcs approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SantiagoDevRel
Copy link
Member

Thanks @bobeu , merged!

@SantiagoDevRel SantiagoDevRel merged commit a2d9cb4 into web3:4.x Feb 19, 2024
12 of 17 checks passed
@bobeu
Copy link
Contributor Author

bobeu commented Feb 19, 2024

Thanks @bobeu , merged!

Thank you @SantiagoDevRel . Shoutout to all the devs.

@Mertz22 Mertz22 mentioned this pull request Mar 24, 2024
Open
@affiliatedkat affiliatedkat mentioned this pull request Mar 24, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Mar 24, 2024
Open
@baophucct baophucct mentioned this pull request Mar 24, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Mar 24, 2024
Open
@baophucct baophucct mentioned this pull request Mar 24, 2024
Open
@adamlaska adamlaska mentioned this pull request Mar 24, 2024
Open
@Itchibon777 Itchibon777 mentioned this pull request Mar 24, 2024
Open
@NaughtyUnicorn24 NaughtyUnicorn24 mentioned this pull request Mar 24, 2024
Open
@vutting4221 vutting4221 mentioned this pull request Mar 24, 2024
Open
@bsmoove247 bsmoove247 mentioned this pull request Mar 24, 2024
Open
@Manny27nyc Manny27nyc mentioned this pull request Mar 25, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Mar 25, 2024
Open
This was referenced Mar 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-io snyk-io bot mentioned this pull request May 21, 2024
Open
This was referenced May 26, 2024
Open
Open
Open
Merged
Merged
Merged
Merged
@chaitanyapotti chaitanyapotti mentioned this pull request May 31, 2024
Closed
@Magd3 Magd3 mentioned this pull request Jun 27, 2024
Open
This was referenced Aug 1, 2024
Open
Open
Open
Open
This was referenced Aug 16, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avkos avkos avkos approved these changes

@jdevcs jdevcs jdevcs approved these changes

@luu-alex luu-alex Awaiting requested review from luu-alex luu-alex is a code owner

@Muhammad-Altabba Muhammad-Altabba Awaiting requested review from Muhammad-Altabba Muhammad-Altabba is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bobeu @SantiagoDevRel @avkos @jdevcs