-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] fix broken link in README to point to correct address (Issue 6817) #6818
Merged
SantiagoDevRel
merged 1 commit into
web3:4.x
from
0xthorazine:fix_readme_tree_shaking_link-6817
Feb 19, 2024
Merged
[DOCS] fix broken link in README to point to correct address (Issue 6817) #6818
SantiagoDevRel
merged 1 commit into
web3:4.x
from
0xthorazine:fix_readme_tree_shaking_link-6817
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #6817 |
avkos
approved these changes
Feb 16, 2024
jdevcs
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @0xthorazine
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6818 +/- ##
==========================================
+ Coverage 87.37% 92.02% +4.65%
==========================================
Files 197 214 +17
Lines 7548 8179 +631
Branches 2059 2201 +142
==========================================
+ Hits 6595 7527 +932
+ Misses 953 652 -301
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Mar 24, 2024
This was referenced Mar 24, 2024
This was referenced Mar 25, 2024
This was referenced May 26, 2024
This was referenced Aug 2, 2024
This was referenced Aug 16, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link in README should point to https://docs.web3js.org/guides/advanced/tree_shaking/ but currently points to https://docs.web3js.org/guides/advanced/web3_tree_shaking_support_guide/
Type of change
Fixed link to correct address