Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3-eth-ens add gettext and getname #6914

Merged
merged 4 commits into from
Mar 25, 2024
Merged

web3-eth-ens add gettext and getname #6914

merged 4 commits into from
Mar 25, 2024

Conversation

luu-alex
Copy link
Contributor

Description

Adding resolver methods gettext and getname in the ens package neccesary for web3modal
Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Mar 22, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 618.7 kB → 619.32 kB (+636 B) +0.10%
Changeset
File Δ Size
../web3-eth-ens/lib/commonjs/resolver.js 📈 +806 B (+14.38%) 5.47 kB → 6.26 kB
../web3-eth-ens/lib/commonjs/ens.js 📈 +793 B (+7.49%) 10.33 kB → 11.11 kB
../web3-eth-ens/lib/commonjs/config.js 📈 +37 B (+1.99%) 1.81 kB → 1.85 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 599.63 kB → 600.25 kB (+636 B) +0.10%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.45 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

github-actions bot commented Mar 22, 2024

Benchmark

Benchmark suite Current: 8bf1e30 Previous: 6c075db Ratio
processingTx 9605 ops/sec (±3.66%) 9301 ops/sec (±4.81%) 0.97
processingContractDeploy 40327 ops/sec (±9.46%) 39129 ops/sec (±7.62%) 0.97
processingContractMethodSend 20433 ops/sec (±6.13%) 19443 ops/sec (±5.19%) 0.95
processingContractMethodCall 41140 ops/sec (±5.14%) 38971 ops/sec (±6.34%) 0.95
abiEncode 46098 ops/sec (±6.25%) 44252 ops/sec (±6.92%) 0.96
abiDecode 31681 ops/sec (±7.20%) 30419 ops/sec (±8.89%) 0.96
sign 1626 ops/sec (±0.41%) 1656 ops/sec (±4.08%) 1.02
verify 378 ops/sec (±2.73%) 373 ops/sec (±0.78%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Merging #6914 (2f71f02) into 4.x (1f81ff0) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

❗ Current head 2f71f02 differs from pull request most recent head 8bf1e30. Consider uploading reports for the commit 8bf1e30 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6914      +/-   ##
==========================================
- Coverage   91.98%   91.94%   -0.04%     
==========================================
  Files         215      215              
  Lines        8174     8186      +12     
  Branches     2207     2207              
==========================================
+ Hits         7519     7527       +8     
- Misses        655      659       +4     
Flag Coverage Δ
UnitTests 91.94% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants