-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6801 Fill gas price when baseFeePerGas==='0x0' #7050
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 2cec997 | Previous: e0fc158 | Ratio |
---|---|---|---|
processingTx |
8934 ops/sec (±4.47% ) |
9220 ops/sec (±3.39% ) |
1.03 |
processingContractDeploy |
39026 ops/sec (±7.25% ) |
37127 ops/sec (±6.27% ) |
0.95 |
processingContractMethodSend |
19250 ops/sec (±4.77% ) |
19169 ops/sec (±7.11% ) |
1.00 |
processingContractMethodCall |
37608 ops/sec (±5.93% ) |
37740 ops/sec (±5.81% ) |
1.00 |
abiEncode |
42743 ops/sec (±6.34% ) |
42093 ops/sec (±6.98% ) |
0.98 |
abiDecode |
29826 ops/sec (±8.29% ) |
28578 ops/sec (±7.99% ) |
0.96 |
sign |
1559 ops/sec (±3.49% ) |
1542 ops/sec (±0.87% ) |
0.99 |
verify |
364 ops/sec (±0.55% ) |
360 ops/sec (±0.57% ) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7050 +/- ##
==========================================
+ Coverage 87.37% 92.01% +4.63%
==========================================
Files 197 215 +18
Lines 7548 8300 +752
Branches 2059 2282 +223
==========================================
+ Hits 6595 7637 +1042
+ Misses 953 663 -290
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog update, thanks
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6801
BSC chain returns
baseFeePerGas==='0x0'
but supports type 2 transactions.Fix is set current
gasPrice
tomaxPriorityFeePerGas
andmaxFeePerGas
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.