-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage increase #7051
coverage increase #7051
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 19602ab | Previous: f4e55bd | Ratio |
---|---|---|---|
processingTx |
8890 ops/sec (±4.02% ) |
9157 ops/sec (±3.53% ) |
1.03 |
processingContractDeploy |
39552 ops/sec (±6.70% ) |
39854 ops/sec (±6.49% ) |
1.01 |
processingContractMethodSend |
18468 ops/sec (±8.65% ) |
19031 ops/sec (±8.97% ) |
1.03 |
processingContractMethodCall |
37510 ops/sec (±5.77% ) |
37579 ops/sec (±6.24% ) |
1.00 |
abiEncode |
42293 ops/sec (±6.73% ) |
42781 ops/sec (±6.77% ) |
1.01 |
abiDecode |
29068 ops/sec (±8.33% ) |
29806 ops/sec (±7.94% ) |
1.03 |
sign |
1541 ops/sec (±0.64% ) |
1522 ops/sec (±3.29% ) |
0.99 |
verify |
356 ops/sec (±2.71% ) |
368 ops/sec (±0.73% ) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. please fix Github Actions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7051 +/- ##
==========================================
+ Coverage 91.97% 92.21% +0.24%
==========================================
Files 215 215
Lines 8291 8329 +38
Branches 2277 2296 +19
==========================================
+ Hits 7626 7681 +55
+ Misses 665 648 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
#7032
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.