-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): contract-tutorial-hardhat-node #7076
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: e3c00a0 | Previous: a7d67c6 | Ratio |
---|---|---|---|
processingTx |
9150 ops/sec (±3.47% ) |
9004 ops/sec (±4.26% ) |
0.98 |
processingContractDeploy |
37287 ops/sec (±7.51% ) |
38832 ops/sec (±7.40% ) |
1.04 |
processingContractMethodSend |
18829 ops/sec (±6.55% ) |
18670 ops/sec (±7.23% ) |
0.99 |
processingContractMethodCall |
37877 ops/sec (±5.23% ) |
37139 ops/sec (±5.60% ) |
0.98 |
abiEncode |
43324 ops/sec (±7.05% ) |
43522 ops/sec (±6.91% ) |
1.00 |
abiDecode |
30363 ops/sec (±6.55% ) |
29115 ops/sec (±7.30% ) |
0.96 |
sign |
1520 ops/sec (±4.03% ) |
1597 ops/sec (±0.97% ) |
1.05 |
verify |
371 ops/sec (±0.52% ) |
369 ops/sec (±0.66% ) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
7b8600b
to
7f453a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7076 +/- ##
==========================================
+ Coverage 87.37% 93.98% +6.61%
==========================================
Files 197 215 +18
Lines 7548 8335 +787
Branches 2059 2301 +242
==========================================
+ Hits 6595 7834 +1239
+ Misses 953 501 -452
Flags with carried forward coverage won't be shown. Click here to find out more.
|
- Ganache has been deprecated, use Hardhat - Use JavaScript instead of TypeScript - Improvements (more links, formatting/consistency) and simplifications
7f453a7
to
4cf44e1
Compare
Any funds sent to them on Mainnet or any other live network WILL BE LOST. | ||
|
||
Account #0: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266 (10000 ETH) | ||
Private Key: 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually when we deal with docs and private keys, we want to hide the actual private keys in case theres a beginner who decides to reuse an exposed key
Private Key: 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 | |
Private Key: privateKey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it...thank you!
This uses a persistent Hardhat development network and would replace #7075