Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction middleware #7088

Merged
merged 16 commits into from
Jun 11, 2024
Merged

transaction middleware #7088

merged 16 commits into from
Jun 11, 2024

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jun 6, 2024

Description

#7002

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Jun 6, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 630.32 kB → 630.55 kB (+242 B) +0.04%
Changeset
File Δ Size
../web3-core/lib/commonjs/web3_context.js 📈 +183 B (+1.35%) 13.26 kB → 13.44 kB
../web3-eth/lib/commonjs/rpc_method_wrappers.js 📈 +287 B (+0.69%) 40.63 kB → 40.92 kB
../web3-eth/lib/commonjs/web3_eth.js 📈 +230 B (+0.25%) 90.54 kB → 90.77 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 611.03 kB → 611.26 kB (+242 B) +0.04%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e633410 Previous: b234c1c Ratio
processingTx 8495 ops/sec (±4.80%) 9042 ops/sec (±4.12%) 1.06
processingContractDeploy 35433 ops/sec (±7.99%) 38054 ops/sec (±6.81%) 1.07
processingContractMethodSend 17411 ops/sec (±7.96%) 18746 ops/sec (±7.29%) 1.08
processingContractMethodCall 35559 ops/sec (±3.96%) 39055 ops/sec (±5.29%) 1.10
abiEncode 38649 ops/sec (±9.54%) 43251 ops/sec (±6.96%) 1.12
abiDecode 28509 ops/sec (±6.46%) 29622 ops/sec (±6.71%) 1.04
sign 1554 ops/sec (±3.64%) 1542 ops/sec (±4.29%) 0.99
verify 363 ops/sec (±0.64%) 363 ops/sec (±1.04%) 1

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.99%. Comparing base (7af8090) to head (e633410).
Report is 3 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7088   +/-   ##
=======================================
  Coverage   93.98%   93.99%           
=======================================
  Files         215      215           
  Lines        8335     8344    +9     
  Branches     2301     2302    +1     
=======================================
+ Hits         7834     7843    +9     
  Misses        501      501           
Flag Coverage Δ
UnitTests 93.99% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@jdevcs jdevcs merged commit 9547643 into 4.x Jun 11, 2024
53 of 54 checks passed
@jdevcs jdevcs deleted the junaid/transactionmiddleware branch June 11, 2024 13:35
@luu-alex luu-alex mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants