-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transaction middleware #7088
transaction middleware #7088
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: e633410 | Previous: b234c1c | Ratio |
---|---|---|---|
processingTx |
8495 ops/sec (±4.80% ) |
9042 ops/sec (±4.12% ) |
1.06 |
processingContractDeploy |
35433 ops/sec (±7.99% ) |
38054 ops/sec (±6.81% ) |
1.07 |
processingContractMethodSend |
17411 ops/sec (±7.96% ) |
18746 ops/sec (±7.29% ) |
1.08 |
processingContractMethodCall |
35559 ops/sec (±3.96% ) |
39055 ops/sec (±5.29% ) |
1.10 |
abiEncode |
38649 ops/sec (±9.54% ) |
43251 ops/sec (±6.96% ) |
1.12 |
abiDecode |
28509 ops/sec (±6.46% ) |
29622 ops/sec (±6.71% ) |
1.04 |
sign |
1554 ops/sec (±3.64% ) |
1542 ops/sec (±4.29% ) |
0.99 |
verify |
363 ops/sec (±0.64% ) |
363 ops/sec (±1.04% ) |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7088 +/- ##
=======================================
Coverage 93.98% 93.99%
=======================================
Files 215 215
Lines 8335 8344 +9
Branches 2301 2302 +1
=======================================
+ Hits 7834 7843 +9
Misses 501 501
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
#7002
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.