Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): mastering-accounts #7089

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix(docs): mastering-accounts #7089

merged 2 commits into from
Jun 10, 2024

Conversation

danforbes
Copy link
Contributor

Streamline Mastering Wallets & Accounts (and rename it to Introduction to Accounts & Wallets). Try to make this page more focused and easier to understand. Remove a lot of the material that is present on other pages and replace it with a "Next Steps" section.

Copy link

github-actions bot commented Jun 7, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 630.32 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 611.03 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 721f615 Previous: 7af8090 Ratio
processingTx 8874 ops/sec (±4.16%) 9348 ops/sec (±3.97%) 1.05
processingContractDeploy 40379 ops/sec (±6.17%) 40452 ops/sec (±6.63%) 1.00
processingContractMethodSend 19214 ops/sec (±6.73%) 19668 ops/sec (±6.95%) 1.02
processingContractMethodCall 40210 ops/sec (±6.18%) 37823 ops/sec (±6.19%) 0.94
abiEncode 44431 ops/sec (±6.95%) 44665 ops/sec (±7.08%) 1.01
abiDecode 30899 ops/sec (±8.60%) 30295 ops/sec (±7.99%) 0.98
sign 1568 ops/sec (±3.69%) 1584 ops/sec (±0.73%) 1.01
verify 379 ops/sec (±0.56%) 371 ops/sec (±2.86%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.98%. Comparing base (7af8090) to head (3dd7932).

Current head 3dd7932 differs from pull request most recent head 721f615

Please upload reports for the commit 721f615 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7089   +/-   ##
=======================================
  Coverage   93.98%   93.98%           
=======================================
  Files         215      215           
  Lines        8335     8335           
  Branches     2301     2301           
=======================================
  Hits         7834     7834           
  Misses        501      501           
Flag Coverage Δ
UnitTests 93.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants