fix waitingforreceipt error #7098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 60a6a8c | Previous: bfe2769 | Ratio |
|---|---|---|---|
processingTx |
9331 ops/sec (±3.76%) |
8959 ops/sec (±4.44%) |
0.96 |
processingContractDeploy |
40651 ops/sec (±7.07%) |
39629 ops/sec (±8.47%) |
0.97 |
processingContractMethodSend |
16659 ops/sec (±7.72%) |
16647 ops/sec (±9.83%) |
1.00 |
processingContractMethodCall |
27939 ops/sec (±8.02%) |
28056 ops/sec (±6.60%) |
1.00 |
abiEncode |
46269 ops/sec (±6.73%) |
43700 ops/sec (±8.36%) |
0.94 |
abiDecode |
30823 ops/sec (±8.08%) |
30625 ops/sec (±8.11%) |
0.99 |
sign |
1590 ops/sec (±2.95%) |
1567 ops/sec (±0.76%) |
0.99 |
verify |
379 ops/sec (±1.15%) |
376 ops/sec (±0.39%) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7098 +/- ##
==========================================
- Coverage 94.75% 94.71% -0.05%
==========================================
Files 215 215
Lines 8334 8339 +5
Branches 2296 2298 +2
==========================================
+ Hits 7897 7898 +1
- Misses 437 441 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
luu-alex
requested review from
avkos,
jdevcs and
Muhammad-Altabba
as code owners
avkos
approved these changes
Jun 17, 2024
jdevcs
reviewed
Jun 19, 2024
jdevcs
reviewed
Jun 25, 2024
| if (typeof error === 'object' && !isNullish(error) && 'message' in error && (error as { message: string }).message === 'transaction indexing is in progress') { | ||
| console.warn('Transaction indexing is in progress.') | ||
| } else { | ||
| throw error; |
There was a problem hiding this comment.
This also should be tested locally with Geth before merging.
There was a problem hiding this comment.
Yup tested locally and works well
Merged
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7007
This was an issue reported internally, waitforreceipt would fail when a new test geth env was set up,
this will catch the error produced. Fixes this problem ethereum/go-ethereum#28877
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.