-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 7055 one of with scalar value and string #7173
Fix 7055 one of with scalar value and string #7173
Conversation
Thanks for submitting the PR! I have some feedback, but overall it looks good :) thanks alot. Also update the changelog. |
Sure. Let me add more tests and update the README |
4b59c10
to
40ddd19
Compare
Thank you @mmyyrroonn for the PR. We will get this in by next release :) |
Description
Fix #7055
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.