Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3 RPC Providers support of configuration of selected transport #7205

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Aug 20, 2024

Description

#7117

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 637.31 kB → 637.83 kB (+534 B) +0.08%
Changeset
File Δ Size
../web3-rpc-providers/lib/commonjs/errors.js 📈 +446 B (+32.72%) 1.33 kB → 1.77 kB
../web3-rpc-providers/lib/commonjs/web3_provider.js 📈 +912 B (+19.11%) 4.66 kB → 5.55 kB
../web3-rpc-providers/lib/commonjs/web3_provider_quicknode.js 📈 +97 B (+1.81%) 5.24 kB → 5.33 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 618.01 kB → 618.53 kB (+534 B) +0.08%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: cbafc92 Previous: d9d0391 Ratio
processingTx 22486 ops/sec (±7.74%) 21240 ops/sec (±7.90%) 0.94
processingContractDeploy 40046 ops/sec (±5.53%) 38066 ops/sec (±7.88%) 0.95
processingContractMethodSend 15305 ops/sec (±9.95%) 15268 ops/sec (±7.65%) 1.00
processingContractMethodCall 28205 ops/sec (±6.87%) 27168 ops/sec (±7.01%) 0.96
abiEncode 44750 ops/sec (±7.42%) 41584 ops/sec (±6.92%) 0.93
abiDecode 31048 ops/sec (±8.20%) 29253 ops/sec (±7.27%) 0.94
sign 1578 ops/sec (±3.63%) 1493 ops/sec (±1.31%) 0.95
verify 375 ops/sec (±0.45%) 360 ops/sec (±0.75%) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (d9d0391) to head (cbafc92).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7205   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files         215      215           
  Lines        8411     8411           
  Branches     2321     2321           
=======================================
  Hits         7946     7946           
  Misses        465      465           
Flag Coverage Δ
UnitTests 94.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jdevcs jdevcs marked this pull request as ready for review August 20, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants