-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web3 RPC Providers support of configuration of selected transport #7205
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: cbafc92 | Previous: d9d0391 | Ratio |
---|---|---|---|
processingTx |
22486 ops/sec (±7.74% ) |
21240 ops/sec (±7.90% ) |
0.94 |
processingContractDeploy |
40046 ops/sec (±5.53% ) |
38066 ops/sec (±7.88% ) |
0.95 |
processingContractMethodSend |
15305 ops/sec (±9.95% ) |
15268 ops/sec (±7.65% ) |
1.00 |
processingContractMethodCall |
28205 ops/sec (±6.87% ) |
27168 ops/sec (±7.01% ) |
0.96 |
abiEncode |
44750 ops/sec (±7.42% ) |
41584 ops/sec (±6.92% ) |
0.93 |
abiDecode |
31048 ops/sec (±8.20% ) |
29253 ops/sec (±7.27% ) |
0.94 |
sign |
1578 ops/sec (±3.63% ) |
1493 ops/sec (±1.31% ) |
0.95 |
verify |
375 ops/sec (±0.45% ) |
360 ops/sec (±0.75% ) |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7205 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 215 215
Lines 8411 8411
Branches 2321 2321
=======================================
Hits 7946 7946
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
#7117
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.