Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accout.signRaw function to sign a message without prefix #7346

Merged
merged 13 commits into from
Nov 4, 2024

Conversation

blackmoshui
Copy link
Contributor

@blackmoshui blackmoshui commented Oct 22, 2024

Description

Fix #6955

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (d3baae6) to head (2a5d298).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7346   +/-   ##
=======================================
  Coverage   94.50%   94.51%           
=======================================
  Files         217      217           
  Lines        8487     8491    +4     
  Branches     2343     2345    +2     
=======================================
+ Hits         8021     8025    +4     
  Misses        466      466           
Flag Coverage Δ
UnitTests 94.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdevcs
Copy link
Contributor

jdevcs commented Oct 24, 2024

@blackmoshui thanks

@blackmoshui
Copy link
Contributor Author

@jdevcs
Copy link
Contributor

jdevcs commented Oct 30, 2024

@blackmoshui before merging this PR, there are merge conflicts needs to be fixed, thanks

@blackmoshui
Copy link
Contributor Author

@blackmoshui before merging this PR, there are merge conflicts needs to be fixed, thanks

Updated.

@jdevcs jdevcs merged commit 4aaf915 into web3:4.x Nov 4, 2024
15 of 18 checks passed
@luu-alex luu-alex mentioned this pull request Nov 6, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add raw hash signing function (without the wrapping in Ethereum message: ...)
4 participants