-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accout.signRaw function to sign a message without prefix #7346
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7346 +/- ##
=======================================
Coverage 94.50% 94.51%
=======================================
Files 217 217
Lines 8487 8491 +4
Branches 2343 2345 +2
=======================================
+ Hits 8021 8025 +4
Misses 466 466
Flags with carried forward coverage won't be shown. Click here to find out more. |
e1cc627
to
32c9f3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackmoshui thanks |
Added. 😄 Thanks for the reminder. |
@blackmoshui before merging this PR, there are merge conflicts needs to be fixed, thanks |
Updated. |
Description
Fix #6955
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.