Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Minor Typographical Errors are Not Accepted #7406

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

danforbes
Copy link
Contributor

Replaces #7405

Added to .github/CONTRIBUTING.md:

Note

Contributions that only address relatively minor typographical errors are not accepted. If you believe you have identified an important typographical error that should be addressed, please open an Issue.

Added to .github/PULL_REQUEST_TEMPLATE.md:

  • Documentation (changes that only address relatively minor typographical errors are not accepted)

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 648.95 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 630.19 kB 0%
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.06 kB 0%
../lib/commonjs/types.d.ts 2.73 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: f38cb07 Previous: 984cb7c Ratio
processingTx 23290 ops/sec (±8.28%) 22676 ops/sec (±7.62%) 0.97
processingContractDeploy 39689 ops/sec (±7.11%) 39814 ops/sec (±6.74%) 1.00
processingContractMethodSend 16404 ops/sec (±7.05%) 16632 ops/sec (±6.54%) 1.01
processingContractMethodCall 28493 ops/sec (±6.22%) 28383 ops/sec (±6.50%) 1.00
abiEncode 44324 ops/sec (±8.68%) 43764 ops/sec (±7.68%) 0.99
abiDecode 31537 ops/sec (±5.75%) 30524 ops/sec (±8.07%) 0.97
sign 1574 ops/sec (±0.87%) 1507 ops/sec (±3.41%) 0.96
verify 364 ops/sec (±0.55%) 369 ops/sec (±0.57%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (984cb7c) to head (f38cb07).
Report is 4 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7406   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         218      218           
  Lines        8557     8557           
  Branches     2364     2364           
=======================================
  Hits         8088     8088           
  Misses        469      469           
Flag Coverage Δ
UnitTests 94.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@danforbes danforbes merged commit acdb0c7 into 4.x Dec 3, 2024
54 checks passed
@danforbes danforbes deleted the chore/docs/typos branch December 3, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants