Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite recursion warning #667

Closed
JeneaVranceanu opened this issue Nov 14, 2022 · 1 comment
Closed

Infinite recursion warning #667

JeneaVranceanu opened this issue Nov 14, 2022 · 1 comment
Labels
bug Something isn't working critical

Comments

@JeneaVranceanu
Copy link
Collaborator

What happened?

Found a warning pointing out an infinite recursion in Utilities/formatToEthereumUnits. Must be fixed.

Screenshot 2022-11-14 at 12 38 19

It appears that one overloaded formatToEthereumUnits function was commented and that created a recursion.
Also there's a formatToPrecision that is commented as well. Must check for recursion.

What are the steps to reproduce?

None. It's an IDE warning.

What is the expected behavior?

No warning and no infinite recursion.

What is the error thrown?

No

What's the stack trace said?

Empty

OS version

Irrelevant

Library version

https://github.com/web3swift-team/web3swift/blob/d8dd9a2614d443d58780e3f190443adbdb5c499e/Sources/Core/Utility/Utilities.swift
@JeneaVranceanu JeneaVranceanu added bug Something isn't working critical labels Nov 14, 2022
@albertopeam albertopeam mentioned this issue Nov 14, 2022
Merged
janndriessen added a commit that referenced this issue Nov 17, 2022
@janndriessen
Merge pull request #668 from albertopeam/bugfix/infinite-recursion-wa…
a3fecba 
…rning

Infinite recursion warning #667
@janndriessen
Copy link
Collaborator

Fixed in #668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janndriessen @JeneaVranceanu