Feature/transaction metadata #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it/web3swift into feature/transaction-metadata * 'feature/transaction-metadata' of https://github.com/mloit/web3swift: update Oracle to use the new metadata struct Back out the workaround implemented tor gasPrice on EIP-1159 transactions Add the new metadata struct to EthereumTransaction Create EthereumMetadata struct and add it to the project
| @@ -117,8 +106,6 @@ extension EIP1559Envelope { | |||
| case v | |||
| case r | |||
| case s | |||
| // MARK: workaround for gasPrice coming from nodes for EIP-1159 - this allows Oracle to work for now | |||
There was a problem hiding this comment.
It's 1559 mistyped to 1159
There was a problem hiding this comment.
indeed, but it's a line being deleted, so no need to fix.
| @@ -147,9 +134,6 @@ extension EIP1559Envelope { | |||
| self.to = ethAddr | |||
| } | |||
|
|
|||
| // MARK: workaround for gasPrice coming from nodes for EIP-1159 - this allows Oracle to work for now | |||
There was a problem hiding this comment.
It's 1559 mistyped to 1159
There was a problem hiding this comment.
copy paste when I did the workaround... this PR is removing it
| @@ -330,10 +336,7 @@ extension EthereumTransaction { | |||
| guard let env = self.envelope as? EIP2930Envelope else { preconditionFailure("Unable to downcast to EIP2930Envelope") } | |||
| return env.parameters.gasPrice ?? 0 | |||
| case .eip1559: | |||
| // MARK: workaround for gasPrice coming from nodes for EIP-1159 - this allows Oracle to work for now | |||
There was a problem hiding this comment.
It's 1559 mistyped to 1159
There was a problem hiding this comment.
see previous comments
mloit
commented
Apr 16, 2022
| @@ -1,6 +1,6 @@ | |||
| Pod::Spec.new do |spec| | |||
| spec.name = 'web3swift' | |||
| spec.version = '2.5.1' | |||
| spec.version = '2.6.0' | |||
There was a problem hiding this comment.
I have no idea why on earth GitHub is flagging this as a change being made here, as develop is 2.6.0 not 2.5.1. This popped up as a result of updating the PR to the latest version of develop when 2.6.0 was released.
yaroslavyaroslav
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new metadata struct that captures and stores additional data that is returned by a node when getting transaction information, but is not part of the transaction itself. This was inspired by the issue of
gasPricedata being present for EIP-1559 transactions, even though EIP-1559 transactions have no such field, butOraclewas written to depend on this data for its calculations. ConsequentlyOraclehas also been updated to use the newmetafield added toEthereumTransaction