feat: added support for JSON RPC Error object #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consider extending error codes to support this list: https://docs.infura.io/infura/networks/ethereum/json-rpc-methods |
| /// This bit of code is purposed to work with literal types that comes in ``Response`` in hexString type. | ||
| /// Currently it's just `Data` and any kind of Integers `(U)Int`, `Big(U)Int`. | ||
| if Result.self == Data.self || Result.self == UInt.self || Result.self == Int.self || Result.self == BigInt.self || Result.self == BigUInt.self { | ||
| guard let LiteralType = Result.self as? LiteralInitiableFromString.Type else { throw Web3Error.typeError } | ||
| if let LiteralType = Result.self as? LiteralInitiableFromString.Type { |
There was a problem hiding this comment.
Oh, that's nice 🙂
Like now we can made this protocol expandable on client side either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an error during the execution of a JSON RPC request we may receive a response containing the error information.
See JSON Error object specification: https://www.jsonrpc.org/specification#error_object
Here is an example of an error before:
And here is the same error after error object parsing was added: