Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ctrl s to download .scn file instead of json #3653

Closed
wants to merge 1 commit into from
Closed

Conversation

lalalune
Copy link
Contributor

@lalalune lalalune commented Aug 18, 2022

Describe your changes

Saves a .scn when user presses ctrl s, which can be easily re-uploaded. Requested by creators to speed up development workflow and use the app as an editor.

What are the steps for a QA tester to test this pull request?

Press ctrl s
Scene should be saved
Verify that scene works by dragging back into window to load

Issue ticket number and link

#3652

Checklist before requesting a review

  • I have performed a self-review of my code
  • I am not adding any irrelevant code or assets
  • I am only including the changes needed to implement the change
  • I have playtested and intentionally tried to find error cases but couldn't

Copy link
Contributor

@avaer avaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is overall good, but given that appManager is already performing a formatting job, IMO it makes sense to move this formatting to appManager.exportJSON.

I don't think there are any other users of that method (it is not how we sync anything).

@lalalune
Copy link
Contributor Author

Closed in favor of Upstreet PR

@lalalune lalalune closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants