Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filament v3 support #22

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Filament v3 support #22

merged 1 commit into from
Jan 2, 2024

Conversation

zhanang19
Copy link
Contributor

Please take a note that this PR is still in progress.

This PR will upgrade this package to be compatible with Filament v3.

Here is how it look like with the new icon:

image

@zhanang19
Copy link
Contributor Author

Also, if you prefer to still adding support for 1.x version, this PR should be merged to a different branch.

@altomar
Copy link

altomar commented Aug 2, 2023

Good work, but Filament v3 has this functionality now
TextColumn::make('email')
->copyable()
->copyMessage('Email address copied')
->copyMessageDuration(1500)

@dmandrade dmandrade changed the base branch from main to 3.x January 2, 2024 12:14
@dmandrade dmandrade marked this pull request as ready for review January 2, 2024 12:15
@dmandrade dmandrade merged commit 6371c87 into webbingbrasil:3.x Jan 2, 2024
1 check passed
@dmandrade
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmandrade dmandrade dmandrade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhanang19 @altomar @dmandrade