Support for Opera Mini #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e manual pagination link.
|
Thank you for your PR. I think the detection code could should be placed in the initialize method around here. I will implement it some other time when I have some more time on my hands. |
|
Ah, good point. If you don't beat me to it, I'll adjust my branch later this week and update the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opera Mini and some other mobile browsers use servers to process JavaScript, then send the result back to the device. Devices like these don't support the Scroll event, so I added a check to the constructor that verifies the browser supports 'onscroll'. If it doesn't, we won't hide the manual pagination link. This allows the plugin to fail gracefully on low-power mobile devices.
I've only been able to test this with Opera Mini for iOS, so verification that it works on other devices/browsers would be appreciated.